Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overflow in stateful sigs tests #1887

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Fix overflow in stateful sigs tests #1887

merged 1 commit into from
Aug 12, 2024

Conversation

SWilson4
Copy link
Member

@SWilson4 SWilson4 commented Aug 9, 2024

Fixes #1886. Thanks @wangweij for the report!

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

@SWilson4
Fix overflow (credit @wangweij)
1aa3d47 
Signed-off-by: Spencer Wilson <[email protected]>
@SWilson4 SWilson4 requested a review from dstebila as a code owner August 9, 2024 17:10
@SWilson4 SWilson4 mentioned this pull request Aug 9, 2024
Closed
@SWilson4
Copy link
Member Author

Merging as-is without Travis passing due to #1888.

@SWilson4 SWilson4 merged commit fc2264d into main Aug 12, 2024
118 of 120 checks passed
@SWilson4 SWilson4 deleted the sw-fix-overflow branch August 12, 2024 19:54
@BrewTestBot BrewTestBot mentioned this pull request Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstebila dstebila dstebila approved these changes

@ashman-p ashman-p ashman-p approved these changes

@cothan cothan Awaiting requested review from cothan

@praveksharma praveksharma Awaiting requested review from praveksharma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

overflow in tests/example_sig_stfl.c
3 participants
@SWilson4 @dstebila @ashman-p